Daniel Bohry 1 год назад
Родитель
Сommit
db94185366
1 измененных файлов с 11 добавлено и 9 удалено
  1. 11 9
      src/main/java/com/danielbohry/stocks/service/PortfolioService.java

+ 11 - 9
src/main/java/com/danielbohry/stocks/service/PortfolioService.java

@@ -34,6 +34,7 @@ public class PortfolioService {
         Portfolio portfolio = repository.findById(id)
                 .orElseThrow(() -> new NotFoundException("No portfolio found with id: " + id));
 
+        log.info("Getting portfolio [{}]", id);
         List<Stock> updatedStocks = portfolio.getStocks().stream()
                 .peek(stock -> {
                     Quote quote = stockService.getStockQuote(stock.getCode());
@@ -76,16 +77,8 @@ public class PortfolioService {
         return repository.save(toUpdate);
     }
 
-    private void validate(List<Stock> stocks) {
-        boolean anyInvalid = stocks.stream()
-                .anyMatch(stock -> !stockService.isValid(stock.getCode()));
-
-        if (anyInvalid) {
-            throw new BadRequestException("Invalid stock found");
-        }
-    }
-
     public void delete(String id) {
+        log.info("Deleting portfolio [{}]", id);
         repository.deleteById(id);
     }
 
@@ -98,4 +91,13 @@ public class PortfolioService {
         });
     }
 
+    private void validate(List<Stock> stocks) {
+        boolean anyInvalid = stocks.stream()
+                .anyMatch(stock -> !stockService.isValid(stock.getCode()));
+
+        if (anyInvalid) {
+            throw new BadRequestException("Invalid stock found");
+        }
+    }
+
 }